Skip to content

Replace code block text with terminal where it was used incorrectly #20185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wkania
Copy link
Contributor

@wkania wkania commented Sep 1, 2024

Console commands in section 5 https://symfony.com/doc/current/contributing/community/reviews.html
Not all console output is displayed as terminal https://symfony.com/doc/current/components/console/helpers/table.html

I have also checked Progress Bar, but the console output there is modified with comments.

@carsonbot carsonbot added this to the 5.4 milestone Sep 1, 2024
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javiereguiluz
Copy link
Member

I like this kind of improvements that make docs (slightly) better. Thanks @wkania.

@javiereguiluz javiereguiluz merged commit d841187 into symfony:5.4 Sep 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants