Skip to content

Update Cidr.rst #20096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Update Cidr.rst #20096

merged 1 commit into from
Aug 6, 2024

Conversation

etshy
Copy link
Contributor

@etshy etshy commented Aug 6, 2024

Update netmaskMax type to match the type in the code (?int).

Update netmaskMax type to match the type in the code.
@etshy etshy requested a review from xabbuh as a code owner August 6, 2024 11:13
@carsonbot carsonbot added this to the 5.4 milestone Aug 6, 2024
@javiereguiluz
Copy link
Member

Good catch @etshy. Thanks and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 96158ed into symfony:5.4 Aug 6, 2024
3 checks passed
@etshy etshy deleted the patch-1 branch August 6, 2024 12:02
@etshy
Copy link
Contributor Author

etshy commented Aug 6, 2024

Thanks @javiereguiluz
Been a while I wanted to do something on symfony or doctrine as I use them a lot and I saw this by coïncidence while searching int arguments on annotation/attributes for a feature I requested on rector so it was perfect opportunity to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants