Skip to content

style: Typo in database.rst title #20067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024
Merged

style: Typo in database.rst title #20067

merged 1 commit into from
Jul 26, 2024

Conversation

sevjan
Copy link
Contributor

@sevjan sevjan commented Jul 25, 2024

No description provided.

@javiereguiluz
Copy link
Member

@sevjan thanks for this contribution.

I know it looks a bit weird at first, but the current text (without the capitalized A) is the correct way of writing this title. The reason is that we use "Title Case" and one of the rules is: "short prepositions (a, to, at, etc.) are not capitalized"

See https://en.wikipedia.org/wiki/Title_case

So, we're closing this one without merging, but we're looking forward to your next contributions. Thanks!

@javiereguiluz
Copy link
Member

I'm reopening this PR because I'm an idiot 😊

As you can see, I "explained" to you which are the title-case rules ... but you already followed those instructions to fix the current issue 🤦

I'm sorry 🙏 Let's merge this.

@javiereguiluz
Copy link
Member

It's merged now! Thanks @sevjan ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 78d9957 into symfony:5.4 Jul 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants