Skip to content

Update security.rst #20042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Update security.rst #20042

merged 1 commit into from
Jul 12, 2024

Conversation

JammyClarkie
Copy link
Contributor

If this form is submitted with an empty username or password, a 400 error will be thrown in a new page: The key "_password" must be a non-empty string. By adding "required" the user will instead get a more helpful "Please fill in this field." error on screen next to the appropriate box which is a much better experience.

@xabbuh xabbuh added this to the 5.4 milestone Jul 12, 2024
If this form is submitted with an empty username or password, a 400 error will be thrown in a new page:  The key "_password" must be a non-empty string.
By adding "required" the user will instead get a more helpful "Please fill in this field." error on screen next to the appropriate box which is a much better experience.
@OskarStark OskarStark changed the base branch from 7.1 to 5.4 July 12, 2024 10:48
@OskarStark OskarStark self-requested a review as a code owner July 12, 2024 10:48
@OskarStark
Copy link
Contributor

OskarStark commented Jul 12, 2024

Thanks for fixing this bug Jonathan and congrats on your first contribution to the Symfony documentation 🎉

@OskarStark OskarStark merged commit 31ced83 into symfony:5.4 Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants