Skip to content

[Lock] Improve the documentation about serializing lock keys #19933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

stof
Copy link
Member

@stof stof commented May 31, 2024

  • use the LockFactory, which is consistent with other examples and is the recommended usage in the fullstack framework rather than injecting the Store to create a Lock directly
  • update the lock store table to document which stores are compatible with serialization, as the section about serialization is linking to this table for compatibility info but it was not included

- use the LockFactory, which is consistent with other examples and is the recommended usage in the fullstack framework rather than injecting the Store to create a Lock directly
- update the lock store table to document which stores are compatible with serialization, as the section about serialization is linking to this table for compatibility info but it was not included
@OskarStark
Copy link
Contributor

Thank you @stof.

@OskarStark OskarStark merged commit 55859c6 into symfony:5.4 Jun 3, 2024
3 checks passed
@stof stof deleted the patch-1 branch October 15, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants