-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[ExpressionLanguage] Add operators precedence documentation #19860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not sure that such a big table is best. I can spread it over 2 columns, or maybe even group all operators that have the same precedence. Also I think I should split between unary and binary operators. |
So I grouped operators by precedence in a second commit. |
@homersimpsons thanks for this. I think it's a good idea to display this information. However, I'm not entirely convinced by these two separate tables. I looked into how other languages solve this:
All of them use a single table and some of these also display the associativity of the operator. So, maybe we can do this:
|
@javiereguiluz I just did the changes |
@homersimpsons this is now merged. Thanks a lot for contributing this. While merging I tweaked this a bit (see c883a11) to:
|
The rendering is not the one I was expecting, I was expecting to see all of those in only 1 cell and not in different cells.
It worked correctly when I tested it in the codespace with the docs builder. I'm not familiar with rst nor with Symfony rendering of this. Do you have any advice? Note that I separated them in multiple rows so it wouldn't take too much width. And this grouping was the most logical. But they all share the same associativity and precedence. |
I recently had the same issue 😊 See #19892 The solution is to add a trailing |
@javiereguiluz I opened #19894 for this |
…impsons) This PR was merged into the 6.4 branch. Discussion ---------- fix expression language precedence cell grouping Fix for #19860 (comment) I do not know how to test the changes as those were working with the doc builder previously. Commits ------- 46562c0 fix expression language precedence cell grouping
Closes #19803