[Clock] Document createFromTimestamp() method #19768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Apr 10, 2024
xabbuh
reviewed
Apr 10, 2024
xabbuh
reviewed
Apr 10, 2024
|
@xabbuh thanks for your review and I'm sorry for these gross mistakes. I was in a rush and I committed without a proper review first. Everything is fixed now. Thanks! |
xabbuh
approved these changes
Apr 10, 2024
javiereguiluz
force-pushed
the
fix_19766
branch
from
745d440 to
9bd321d
Compare
|
Thank you for your work on this, @javiereguiluz! I think, it is worth mentioning that this method is part of a set of (more undocumented) polyfills. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19766