Skip to content

[DependencyInjection] Update shared.rst to add doc on PHP attributes #19698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

arnissolle
Copy link
Contributor

Add code block for PHP attributes.

@arnissolle arnissolle force-pushed the patch-1 branch 2 times, most recently from f087713 to bcfc957 Compare March 22, 2024 09:51
@carsonbot carsonbot changed the title Update shared.rst to add doc on PHP attributes [DependencyInjection] Update shared.rst to add doc on PHP attributes Mar 22, 2024
@javiereguiluz javiereguiluz added this to the 5.4 milestone Mar 22, 2024
Add code block for PHP attributes
@javiereguiluz
Copy link
Member

Pierre, thanks a lot for improving the docs ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit ecc1b56 into symfony:5.4 Mar 22, 2024
@arnissolle arnissolle deleted the patch-1 branch March 22, 2024 14:48
@arnissolle
Copy link
Contributor Author

arnissolle commented Mar 22, 2024

⚠️ @javiereguiluz @xabbuh the doc is broken, is there something missing in the code block?

Capture d’écran 2024-03-22 à 18 46 21

@xabbuh
Copy link
Member

xabbuh commented Mar 27, 2024

@arnissolle Thanks for the heads up. I guess this is due to the fact that there was a tab instead of four spaces (dda1b38 should fix that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants