[HttpKernel] Explain how to define default value in MapQueryString #19627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Mar 5, 2024
| @@ -451,6 +451,24 @@ HTTP status to return if the validation fails:: | |||
|
|
|||
| The default status code returned if the validation fails is 404. | |||
|
|
|||
| If the request query string is empty and if you still need to have a valid DTO, you can | |||
| define a default value in your controller method:: | |||
There was a problem hiding this comment.
Suggested change
| define a default value in your controller method:: | |
| define a default value to your controller parameter:: |
There was a problem hiding this comment.
I tweaked this while merging ... but apparently, the correct preposition here is for instead of to 😊 Thanks!
Comment on lines
+470
to
+471
| In this case your DTO should have default values. | ||
|
|
There was a problem hiding this comment.
I think this line may be superfluous 🙂
There was a problem hiding this comment.
Yes, I removed it while merging. Thanks.
|
Neil, thanks a lot for this improvement ... and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The current example of how using a
MapQueryStringattribute is not really clear about default DTO value. Some people expects to have a new instance of their DTO.The goal of this PR is to add a bit of details about how to define this default value.
see #54042