Skip to content

[AssetMapper] Deleting duplicated info #19617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

ThomasLandauer
Copy link
Contributor

Page: https://symfony.com/doc/6.4/frontend/asset_mapper.html#deploying-with-the-assetmapper-component

Reason: This is all explained in detail under the very next heading.

@ThomasLandauer
Copy link
Contributor Author

Plus adding more details about the JSON files (commit 2). If you don't merge this, I'll still open a separate PR with only this part.

@javiereguiluz
Copy link
Member

Thanks Thomas.

I agree on removing the duplicated text. However, I disagree with some proposed changes:

  • We prefer to not list exhaustively internal details like all the JSON files generated by AssetMapper. This could change, so it would make docs harder to maintain. Instead I listed only two of those JSON files and added an etc.
  • I readded the mention to the "optimization of importmap" because that's the exact reason why all these files are generated.

See ef2c3b2

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants