Skip to content

[Routing] Update routing.rst #19613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

vimalgorasiya
Copy link
Contributor

Hello,

This pull request enhances the code snippets under the Matching HTTP Methods section by adding the missing import namespaces for Symfony components. The updated code in src/Controller/BlogApiController.php now includes the necessary use statements, ensuring clarity and correctness.

If further improvements or updates are needed, please let me know.

Thanks.

@javiereguiluz javiereguiluz added this to the 6.4 milestone Feb 28, 2024
@carsonbot carsonbot changed the title Update routing.rst [Routing] Update routing.rst Feb 28, 2024
@javiereguiluz
Copy link
Member

Vimal, thanks for this contribution.

In Symfony Docs, we usually only show the full use statements the first time they are used ... the rest of the examples of the same page just show the // ... instead of repeating the imports. But, in this case this is the second time these imports appear ... and the first time it's a bit disconnected from this one. So, let's merge it.

So, generally speaking, let's not replace // ... in all the examples by the actual import ... only if they haven't been included before in the same page. Thanks!

Congrats on your first Symfony Docs contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants