Skip to content

[AssetMapper] Adding updater to comparison table #19564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

ThomasLandauer
Copy link
Contributor

@ThomasLandauer ThomasLandauer commented Feb 15, 2024

Page: https://symfony.com/doc/6.4/frontend.html#using-php-twig

Reason: It's a cool feature :-)

@javiereguiluz
Copy link
Member

The new entry is a bit confusing. I'd change it for Can update 3rd party packages

If that's the true mining of what we're adding here ... I'm not sure we should say yes for Webpack Encore because it doesn't include any command/feature to update packages. AssetMapper has importmap:update but Encore has nothing like it (you can update packages with npm, yarn, etc. ... but that's not Encore).

@ThomasLandauer
Copy link
Contributor Author

I updated the wording. Maybe add a link to npm-check?
2 arguments for this change:

  • When switching from Encore to AssetMapper, it's important to know that there is still an updater.
  • People not familiar with JS bundlers might not know that NPM has one.

@smnandre
Copy link
Member

AssetMapper has importmap:update but Encore has nothing like it (you can update packages with npm, yarn, etc. ... but that's not Encore).

Hmm.. to be honest Encore has nothing like it because... if you have Encore you have yarn or npm or pnpm or (...) for that :) So Encore would have no reason to implement such command.

I'm thinking all the lines have really different "importances" in term of comparaison, and we may want to split the table in distinct aspects (compatibility, dx, standards, ..)

@javiereguiluz javiereguiluz merged commit 89454df into symfony:6.4 Mar 25, 2024
@javiereguiluz
Copy link
Member

Thanks Thomas! While merging I changed the value of this row for Encore to say no instead of yes (see 0a67190). Encore doesn't have any feature to update packages. You can do it via npm, but that's not encore. Thanks!

@ThomasLandauer ThomasLandauer deleted the patch-14 branch March 25, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants