[Container] Small typos #19546
Merged
[Container] Small typos #19546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Feb 12, 2024
xabbuh
requested changes
Feb 12, 2024
service_container.rst
Outdated
| @@ -1257,7 +1257,7 @@ unique string as the key of each service config: | |||
| event_subscribers: | |||
| namespace: App\Domain\ | |||
| resource: '../src/Domain/*/EventSubscriber' | |||
| tags: [event_subscriber] | |||
| tags: [kernel.event_subscriber] | |||
There was a problem hiding this comment.
I think that the example deliberately used event_subscriber as a tag (matching the custom command_handler tag used above).
There was a problem hiding this comment.
Yeah, I checkout this change, thanks
chadyred
force-pushed
the
doc/typo-service-container
branch
from
b2cd464 to
2abf844
Compare
xabbuh
approved these changes
Feb 12, 2024
xabbuh
force-pushed
the
doc/typo-service-container
branch
from
2abf844 to
9b1c4b9
Compare
|
Good catch, thanks @chadyred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://symfony.com/doc/current/reference/dic_tags.html#kernel-event-subscriber