Skip to content

[AssetMapper] Minor #19539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024
Merged

[AssetMapper] Minor #19539

merged 1 commit into from
Mar 1, 2024

Conversation

ThomasLandauer
Copy link
Contributor

Page: https://symfony.com/doc/6.4/frontend/asset_mapper.html#handling-css

This is indeed better than #19453 was; and much better than before.

  1. "valid" in which sense? Valid importmap syntax?

  2. What about something like:

    These special entries are valid importmap syntax, but ignored by JavaScript.

    Then the last sentence could be shortened.

Page: https://symfony.com/doc/6.4/frontend/asset_mapper.html#handling-css

This is indeed better than symfony#19453 was; and much better than before.

1. "valid" in which sense? Valid importmap syntax?
@javiereguiluz
Copy link
Member

Thanks!

@javiereguiluz javiereguiluz merged commit 58e888b into symfony:6.4 Mar 1, 2024
@ThomasLandauer ThomasLandauer deleted the patch-10 branch March 1, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants