[Security] [DOC] Update passwords.rst #19396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
The signature of the needsRehash method of the `SymfonyComponentPasswordHasher\Hasher\UserPasswordHasherInterface` interface is `public function needsRehash(PasswordAuthenticatedUserInterface $user): bool;`. If we use the method `public function needsRehash(string $hashedPassword): bool;`, then the interface should be `Symfony\Component\PasswordHasher\PasswordHasherInterface`.
|
I'm merging this because it looks correct to me. If we want to use the other interface, then we'll update the code to use the proper method arguments. Thanks Franklin! |
javiereguiluz
force-pushed
the
patch-2
branch
from
adadd83 to
088a4f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of the needsRehash method of the
SymfonyComponentPasswordHasher\Hasher\UserPasswordHasherInterfaceinterface ispublic function needsRehash(PasswordAuthenticatedUserInterface $user): bool;.If we use the method
public function needsRehash(string $hashedPassword): bool;, then the interface should beSymfony\Component\PasswordHasher\PasswordHasherInterface.