Skip to content

[Dotenv] Fix incorrect way to modify .env path #19377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

alexandre-daubois
Copy link
Member

@carsonbot carsonbot added this to the 7.1 milestone Jan 3, 2024
@carsonbot carsonbot changed the title [DotEnv] Fix incorrect way to modify .env path [Dotenv] Fix incorrect way to modify .env path Jan 3, 2024
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing this, Alex.

Also, I think we need to remove the caution that mentions the SYMFONY_DOTENV_PATH env var.

@alexandre-daubois alexandre-daubois force-pushed the fix-dotenv branch 3 times, most recently from d6df9c8 to 2f9b1de Compare January 9, 2024 07:25
@javiereguiluz
Copy link
Member

Glad to see this PR completed and now merged. Alex, thanks a lot for your patience during the review process.

@javiereguiluz javiereguiluz merged commit b3c5187 into symfony:7.1 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants