Skip to content

[Form] Document using TranslatableMessage in form Fields #19246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2023
Merged

[Form] Document using TranslatableMessage in form Fields #19246

merged 1 commit into from
Dec 9, 2023

Conversation

SebLevDev
Copy link
Contributor

Document using TranslatableMessage for button_label and placeholder like form help (#15527)
#SymfonyHackday

@SebLevDev SebLevDev requested a review from xabbuh as a code owner December 9, 2023 13:38
@carsonbot carsonbot added this to the 6.4 milestone Dec 9, 2023
@OskarStark
Copy link
Contributor

This is possible since 5.4 isn't it?

@SebLevDev
Copy link
Contributor Author

SebLevDev commented Dec 9, 2023 •
edited
Loading

This is possible since 5.4 isn't it?

I think, i can change target branch to 5.4

@SebLevDev SebLevDev changed the base branch from 6.4 to 5.4 December 9, 2023 14:18
@SebLevDev SebLevDev force-pushed the form_transalteble_fields branch from b29e238 to 5ac1a00 Compare December 9, 2023 14:21
@wouterj wouterj modified the milestones: 6.4, 5.4 Dec 9, 2023
@OskarStark
Copy link
Contributor

Thank you @SebLevDev.

@OskarStark OskarStark merged commit 0978b97 into symfony:5.4 Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Form Hack Day Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@SebLevDev @OskarStark @wouterj @carsonbot