Skip to content

add router.request_context.base_url to cookbook entry #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2012
Merged

add router.request_context.base_url to cookbook entry #1916

merged 2 commits into from
Nov 23, 2012

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Nov 12, 2012

documentation for symfony/symfony#5983

@wouterj
Copy link
Member

wouterj commented Nov 12, 2012

You should place a .. versionadded: 2.2 block somewhere before you start using the new feature.

@dbu
Copy link
Contributor Author

dbu commented Nov 12, 2012

there is no such block for the other parameters, so i am unsure how to put this.

would it make sense like this?

.. versionadded: 2.1

    The host and scheme parameters are available since Symfony 2.1

.. versionadded: 2.2

    The base_url parameter is available since Symfony 2.2

if not, do you have an example somewhere in the doc that i could use as inspiration?

@wouterj
Copy link
Member

wouterj commented Nov 12, 2012

I think it is great, but @weaverryan has maybe another idee? You can see this blocks everywhere in the docs, a good block is 1 line (72) characters long. A good example: http://symfony.com/doc/current/book/forms.html#groups-based-on-submitted-data

@dbu
Copy link
Contributor Author

dbu commented Nov 13, 2012

ok, added exactly as proposed.

weaverryan added a commit that referenced this pull request Nov 23, 2012
weaverryan added a commit that referenced this pull request Nov 23, 2012
@weaverryan weaverryan merged commit 7069e85 into symfony:master Nov 23, 2012
@weaverryan
Copy link
Member

Hey David!

Thanks for the PR! I've merged this in and tweaked/fixed a few other things we needed in the 2.0 and 2.1 branches that we needed for the existing "new-in-2.1" features.

Thanks!

@dbu dbu deleted the patch-1 branch February 20, 2015 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants