[Dotenv] Mention the overrideExistingVars parameter of DotEnv
#19082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
overrideExistingVars parameter of DotEnvoverrideExistingVars parameter of DotEnv
OskarStark
reviewed
Oct 25, 2023
| use Symfony\Component\Dotenv\Dotenv; | ||
|
|
||
| $dotenv = new Dotenv(); | ||
| $dotenv->loadEnv(__DIR__.'/.env', null, 'dev', ['test'], true); |
There was a problem hiding this comment.
I would use named arguments here and only add the required one + the overrideExistingVars parameter
There was a problem hiding this comment.
Yes but 5.4 minimal req is PHP 7.2. Shouldn't the example be compatible with the lowest possible PHP version ?
There was a problem hiding this comment.
Oh indeed, but we can do it after upmerge
There was a problem hiding this comment.
I'll provide the PR 🙂
OskarStark
approved these changes
Oct 25, 2023
|
Open for a PR to adjust the PHPDoc in the code repo, like proposed by stof? |
oleg-andreyev
approved these changes
Oct 25, 2023
|
Here you go 🙂 |
|
Nice contribution as always. Thanks Alex! |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Oct 26, 2023
…re-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Dotenv] Add PHPDoc for `$overrideExistingVars` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Following symfony/symfony-docs#19082 (comment) Commits ------- 218a4ac [Dotent] Add PHPDoc for `$overrideExistingVars`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to symfony/symfony#52090
I think this is a good place to mention it, as the DotEnv component doesn't have a proper documentation page