[Workflow] Revert deprecation about Registry #19065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
reviewed
Oct 20, 2023
| Beware that injecting the ``Registry`` into your services is **not** | ||
| recommended. Indeed, it prevents some optimization like lazy-loading | ||
| from working and could be a performance hog. Instead, you should always | ||
| inject the workflow you need. |
There was a problem hiding this comment.
Do we talks about TaggedIterator('workflow') or TaggedLocator('workflow') somewhere?
If not we should talk about this before talking about the registry
There was a problem hiding this comment.
We do, in the tip section here: https://symfony.com/doc/current/workflow.html#accessing-the-workflow-in-a-class
|
Thank you Alexandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19010
Friendly ping @lyrixx 🙂