Skip to content

Doctor RST ensure link definitions bottom #19028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Doctor RST ensure link definitions bottom #19028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .doctor-rst.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ rules:
ensure_bash_prompt_before_composer_command: ~
ensure_exactly_one_space_before_directive_type: ~
ensure_exactly_one_space_between_link_definition_and_link: ~
ensure_link_bottom: ~
ensure_link_definition_contains_valid_url: ~
ensure_order_of_code_blocks_in_configuration_block: ~
ensure_php_reference_syntax: ~
Expand Down
4 changes: 2 additions & 2 deletions contributing/code/conventions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,6 @@ after the use declarations, like in this example from `ServiceRouterLoader`_::
*/
class ServiceRouterLoader extends ObjectRouteLoader

.. _`ServiceRouterLoader`: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Routing/Loader/DependencyInjection/ServiceRouterLoader.php

The deprecation must be added to the ``CHANGELOG.md`` file of the impacted component:

.. code-block:: markdown
Expand Down Expand Up @@ -239,3 +237,5 @@ Commands and their options should be named and described using the English
imperative mood (i.e. 'run' instead of 'runs', 'list' instead of 'lists'). Using
the imperative mood is concise and consistent with similar command-line
interfaces (such as Unix man pages).

.. _`ServiceRouterLoader`: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Routing/Loader/DependencyInjection/ServiceRouterLoader.php
7 changes: 3 additions & 4 deletions frontend/encore/faq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,6 @@ For performance, Encore does not process libraries inside ``node_modules/`` thro
Babel. But, you can change that via the ``configureBabel()`` method. See
:doc:`/frontend/encore/babel` for details.

.. _`rsync`: https://rsync.samba.org/

How Do I Integrate my Encore Configuration with my IDE?
-------------------------------------------------------

Expand Down Expand Up @@ -168,8 +166,6 @@ running it (e.g. when executing ``yarn encore dev``). Fix this issue calling to

// ... the rest of the Encore configuration

.. _`Webpack integration in PhpStorm`: https://www.jetbrains.com/help/phpstorm/using-webpack.html

My Tests are Failing Because of ``entrypoints.json`` File
---------------------------------------------------------

Expand All @@ -194,3 +190,6 @@ functions to trigger exceptions when there's no ``entrypoints.json`` file):
webpack_encore:
strict_mode: false
# ...

.. _`rsync`: https://rsync.samba.org/
.. _`Webpack integration in PhpStorm`: https://www.jetbrains.com/help/phpstorm/using-webpack.html