Skip to content

Mention PCNTL extension installation #19026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

alexandre-daubois
Copy link
Member

May fix #19006

@carsonbot carsonbot added this to the 5.4 milestone Oct 16, 2023
setup.rst Outdated
Comment on lines 25 to 28
Symfony application locally. Also, you may install the `PCNTL`_ extension to
use some features like signal handling in
:doc:`the Messenger component </messenger>` and when using
:ref:`signals in commands <console_signal-event>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed. There are more "optional extensions" in Symfony components. We should document these when you need it (like you did in this PR), but we shouldn't mention it in the general set-up guide (set-up should be quick and simple)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree ... the setup.rst article is both special and very important. Every item we add to the "list of things to check" creates friction for new people using Symfony.

Given that this PCNTL extension is only needed in some very small and specific parts of some Symfony components, I wouldn't mention it in this article. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, that's removed. Thank you for the review!

@javiereguiluz
Copy link
Member

Very nice! Thanks a lot Alex.

@javiereguiluz javiereguiluz merged commit 370e0d3 into symfony:5.4 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants