Skip to content

[Console] Dispatch ConsoleTerminateEvent when exiting on signal #19017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2023
Merged

[Console] Dispatch ConsoleTerminateEvent when exiting on signal #19017

merged 2 commits into from
Oct 13, 2023

Conversation

alexandre-daubois
Copy link
Member

Fix #19016

@carsonbot carsonbot added this to the 6.4 milestone Oct 13, 2023
OskarStark
OskarStark reviewed Oct 13, 2023
View reviewed changes
OskarStark
OskarStark approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my comment

@OskarStark
Copy link
Contributor

Thank you Alexandre.

@OskarStark OskarStark merged commit a6cabb2 into symfony:6.4 Oct 13, 2023
@alexandre-daubois alexandre-daubois deleted the event-on-exit-signal branch October 13, 2023 10:27
@alexandre-daubois
Copy link
Member Author

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[Console] Dispatch ConsoleTerminateEvent when exiting on signal
3 participants
@alexandre-daubois @OskarStark @carsonbot