Skip to content

Update migration.rst #19015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Update migration.rst #19015

merged 1 commit into from
Oct 12, 2023

Conversation

gpetraroli
Copy link
Contributor

Change return type of handleRequest to void

@OskarStark
Copy link
Contributor

Should target 5.4 branch, right?

@gpetraroli
Copy link
Contributor Author

Only 6.3 doc is concerned I think

@artyuum
Copy link
Contributor

artyuum commented Oct 12, 2023

@gpetraroli there is another type error here (in case you want to fix that as well), the function return type is set as string but it's not returning anything:

symfony-docs/migration.rst

Lines 463 to 473 in b3d1030

return new StreamedResponse(
function () use ($requestPath, $legacyScript): string {
$_SERVER['PHP_SELF'] = $requestPath;
$_SERVER['SCRIPT_NAME'] = $requestPath;
$_SERVER['SCRIPT_FILENAME'] = $legacyScript;
chdir(dirname($legacyScript));
require $legacyScript;
}
);

@gpetraroli
Copy link
Contributor Author

Thank you, I will

@gpetraroli gpetraroli marked this pull request as draft October 12, 2023 13:38
@gpetraroli gpetraroli marked this pull request as ready for review October 12, 2023 13:46
@gpetraroli gpetraroli requested a review from artyuum October 12, 2023 13:47
@javiereguiluz javiereguiluz added this to the 6.3 milestone Oct 12, 2023
@javiereguiluz
Copy link
Member

Thanks Giuseppe and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 1937a79 into symfony:6.3 Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants