Pass Request to EntityValueResolver
#18991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
Request to EntityValueResolverRequest to EntityValueResolver
94noni
reviewed
Oct 5, 2023
doctrine.rst
Outdated
| public function show( | ||
| Product $product, | ||
| #[MapEntity(expr: 'repository.findBy(["product_id" => id], null, request.query.get("limit", 10)')] | ||
| Comment $comment |
There was a problem hiding this comment.
shouldn'it be an array/collection ? due to the findBy
There was a problem hiding this comment.
That's right, thanks!
alexandre-daubois
force-pushed
the
request-expression-value-resolver
branch
from
57f3cac to
665f51d
Compare
94noni
reviewed
Oct 6, 2023
doctrine.rst
Outdated
| @@ -746,6 +746,23 @@ In the example above, the ``$product`` argument is handled automatically, | |||
| but ``$comment`` is configured with the attribute since they cannot both follow | |||
| the default convention. | |||
|
|
|||
| If you need to get other information from the request to fetch your entity, you | |||
There was a problem hiding this comment.
nitpick, but then this should be your entities, or at least your data ^^
There was a problem hiding this comment.
Reworded to match any case 👌
94noni
approved these changes
Oct 6, 2023
alexandre-daubois
force-pushed
the
request-expression-value-resolver
branch
from
665f51d to
8be44d7
Compare
|
Thank you Alexandre. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18987