[Security] Improve requires_channel var naming
#18976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
approved these changes
Oct 3, 2023
OskarStark
approved these changes
Oct 3, 2023
|
A nice little improvement! @momito69 thanks and congrats on your first Symfony Docs contribution 🎉 |
|
@javiereguiluz @alexandre-daubois thank you guys ! Happy to help ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with this part of the doc, I found confusing having a env var named
SECURE_SCHEME. Indeed, as stated in the same section, this env var could take thehttpvalue when in dev environment which could lead to some confusion. I suggest to improve the naming of this env var in order to clarify the example.