Add new Twig bridge function to generate impersonation path #18966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
alexandre-daubois
force-pushed
the
twig-bridge-impersonation
branch
from
49a311c to
4f9bfaa
Compare
alexandre-daubois
force-pushed
the
twig-bridge-impersonation
branch
from
4f9bfaa to
061bc3f
Compare
OskarStark
approved these changes
Oct 2, 2023
|
Alex, thanks for this contribution and for fixing the code of this feature too |
This was referenced Oct 4, 2023
OskarStark
added a commit
that referenced
this pull request
Oct 30, 2023
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- Document twig functions on impersonation i am updating one of my app to 6.4 and also reading some https://symfony.com/blog/category/living-on-the-edge/7.0-6.4 found this was not yet documented from https://symfony.com/blog/new-in-symfony-6-4-impersonation-utilities edit: following code PR comment on Symfony-docs repo, found #18966 to me this is uselefull here as well as more "usage dev doc" instead of "TOC doc", wdyt? FYO when googling "symfony user switch" the first link is the page I am proposing to edit thx Commits ------- 5c04c6b Document twig functions on impersonation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Fix
impersonation_path()argument mandatory and add `impe… #18968However, I think we should wait for this PR to be merged (or not), because it seems the current implementation has a problem:
impersonation_path()argument mandatory and addimpersonation_url()symfony#51804This doc PR takes into account my fix PR above.Merged 👍