[Console] Fix codeblock markup #18937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Sep 29, 2023
OskarStark
approved these changes
Sep 29, 2023
| @@ -585,7 +585,7 @@ call ``setAutoExit(false)`` on it to get the command result in ``CommandTester`` | |||
| When testing your commands, it could be useful to understand how your command | |||
| reacts on different settings like the width and the height of the terminal. | |||
| You have access to such information thanks to the | |||
| :class:`Symfony\\Component\\Console\\Terminal` class: | |||
| :class:`Symfony\\Component\\Console\\Terminal` class:: | |||
There was a problem hiding this comment.
Can we spot this automatically @alamirault
Any idea?
There was a problem hiding this comment.
I think we can't or it will be very hard.
Malformed Literal blocks can be confused with a lot other RST blocks.
Following regex can be a start .+:\n\n , but we must exclude a lot of false positive
|
Thanks for fixing this bug Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug visible on
5.46.26.36.4&7.0