Skip to content

[Validator] Translate validator message in docs #18885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

VoodooPrograms
Copy link
Contributor

No description provided.

@javiereguiluz javiereguiluz added this to the 6.3 milestone Sep 19, 2023
@javiereguiluz javiereguiluz merged commit 76eebec into symfony:6.3 Sep 19, 2023
@javiereguiluz
Copy link
Member

Bartosz, thanks and congrats on your first Symfony Docs contribution 🎉

The problem here is that the message option is only useful to change the default message. Your PR proposes to use the default message, so it can be a bit confusing.

Originally, we used a message in French to show hat you can use a totally custom message. I can see how using a non-English message can be confusing too here ... so, while merging, I reworded your PR a bit to use a custom message but in English. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants