[Translation] Fix default-path XML config
#18872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
default-path XML configdefault-path XML config
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Sep 19, 2023
…` in XML (HeahDude) This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] Fix support for `translator.default_path` in XML | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | symfony/symfony-docs#18872 The docs is currently wrong assuming there is an element `default-path` using XML config, https://symfony.com/doc/current/translation.html#configuration. It appears it's missing in the XSD, but IMO it should be added as an attribute. Commits ------- 3534118 [Translator] Fix support for `default_path` in XML
|
symfony/symfony#51671 has been merged. |
javiereguiluz
removed
the
Waiting Code Merge
|
It's great that you could fix this bug that you found while contributing to docs. Thanks Jules! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: we should wait for symfony/symfony#51671 to be merged first.