[Security] Add RateLimiter requirement command #18857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alex, I love this kind of contributions because it removes any potential confusion when trying to use this feature. However, when merging it I changed a bit the location of the new text. The common practice in other articles is to show as early as possible the fact that you need to install a certain component to use the feature. See 2cbbb39 Thanks! |
|
Got it! 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17966
I was not able to reproduce ticket's owner error. However, I faced a missing requirement error when trying. I propose to add this code bock to fix this instead of facing a dependency error 👍