Skip to content

[Config] [Configuration] Emphasize env vars purpose #18850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

alexandre-daubois
Copy link
Member

Fix #14745

@carsonbot carsonbot added this to the 5.4 milestone Sep 8, 2023
Copy link
Contributor

@94noni 94noni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like the paragraph mostly
small comments as well

@carsonbot carsonbot changed the title [Configuration] Emphasize env vars purpose [Config] [Configuration] Emphasize env vars purpose Sep 11, 2023
@javiereguiluz javiereguiluz merged commit 569fc12 into symfony:5.4 Sep 11, 2023
@javiereguiluz
Copy link
Member

Alex, this was a nice contribution as always.

However, while merging I notices that the new note explained a use case for env vars ... but in the intro of this section we mentioned another use case. So, I removed the note and merged its contents into the section intro to make it easier to readers. See 149876b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants