[Mailer][Messenger] Mention that emails are async when using Messenger #18848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
alexandre-daubois
approved these changes
Sep 8, 2023
94noni
reviewed
Sep 8, 2023
| If you prefer to send emails asynchronously to improve performance, read the | ||
| :ref:`Sending Messages Async <mailer-sending-messages-async>` section. Also, if | ||
| your application has the :doc:`Messenger component </messenger>` installed, all | ||
| emails will be sent asynchronously by default |
There was a problem hiding this comment.
Suggested change
| emails will be sent asynchronously by default | |
| emails will be sent asynchronously by default (you will need to have a worker/consumer running) |
isnt it?
There was a problem hiding this comment.
Yes ... but I think that at this point that is "an implementation detail". All this, and more, is explained in the linked section. That's why I think it's not necessary to repeat it here.
javiereguiluz
force-pushed
the
fix_17072
branch
from
af35be3 to
585b8a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17072.