Skip to content

[Testing] Create a section dedicated to sending multiple requests in one functional test #18789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

MatTheCat
Copy link
Contributor

The current documentation just issues a warning which is not enough to become aware of the gotchas (see symfony/symfony#46206 for example).

@carsonbot carsonbot added this to the 6.4 milestone Aug 26, 2023
@MatTheCat MatTheCat changed the base branch from 6.4 to 5.4 August 26, 2023 09:43
@MatTheCat MatTheCat force-pushed the app-test-many-requests branch 3 times, most recently from 0ab8a45 to b665b5e Compare September 6, 2023 14:30
@MatTheCat MatTheCat force-pushed the app-test-many-requests branch from b665b5e to b377285 Compare September 8, 2023 07:47
Copy link
Member

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a bit of rewording will be done at merge to match the rest of the doc but LGTM overall 🙂

@javiereguiluz javiereguiluz modified the milestones: 6.4, 4.4, 5.4 Sep 11, 2023
@javiereguiluz javiereguiluz merged commit 8aa3364 into symfony:5.4 Sep 11, 2023
@javiereguiluz
Copy link
Member

Very nice contribution. I did some minor rewording while merging but the core of your contribution remained. Thanks Mathieu!

@MatTheCat MatTheCat deleted the app-test-many-requests branch September 12, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants