Clearer difference with max and quiet options #18786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Aug 28, 2023
| @@ -325,6 +325,10 @@ It's also possible to change verbosity per deprecation type. For example, using | |||
| ``quiet[]=indirect&quiet[]=other`` will hide details for deprecations of types | |||
| "indirect" and "other". | |||
|
|
|||
| Note that `quiet` hides details for the specified deprecation types, but will | |||
There was a problem hiding this comment.
Suggested change
| Note that `quiet` hides details for the specified deprecation types, but will | |
| .. note:: | |
| `quiet` hides details for the specified deprecation types, but will |
Please use 2 backticks before and after quite and max, thanks
There was a problem hiding this comment.
I added the two backticks while merging. I didn't add the .. note:: directive because this section is short and the directive breaks the reading flow. Thanks.
greg0ire
approved these changes
Aug 28, 2023
|
Florian, thanks and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First contribution here so I hope that I didn't made a mistake. Let me know if I need to change or point a process I missed.
As discussed on the symfony/symfony#46497, the difference between
quietandmaxmay be unclear. In addition the behavior existing before 5.4 might have been erroneous. As the change is hard to retrieve and impossible to fix now, we come to the conclusion that a doc update may help to fix end user issue with this change.Let me know if the added paragraph needs to be clearer or at another place or if it needs to be rephrased as English is not my first language. I also wanted to make a link to the section which talk about
maxand making tests fail. I hope this is the right way.Thanks for reading. :-)