[Routing] Update page_creation.rst remove confusing unstyled diff symbol #18763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a left over from docs showing both annotation and attribute route methods. The plus sign isn't handled because the code block is not a diff. Issue was brought up by a confused user.
xabbuh
reviewed
Aug 18, 2023
| @@ -104,7 +104,7 @@ You can now add your route directly *above* the controller: | |||
| // src/Controller/LuckyController.php | |||
|
|
|||
| // ... | |||
| + use Symfony\Component\Routing\Annotation\Route; | |||
| use Symfony\Component\Routing\Annotation\Route; | |||
There was a problem hiding this comment.
we also need to remove the plus character on lines 111 to 113 as well as on lines 125 and 129
There was a problem hiding this comment.
I removed the extra + while merging. Thanks!
carsonbot
changed the title
|
Good catch David! Thanks and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a left over from docs showing both annotation and attribute route methods. The plus sign isn't handled because the code block is not a diff. Issue was brought up by a confused user who thought that the plus sign was required syntax.