Skip to content

[Frontend] Create a UX bundle: add requirements for Asset Mapper #18755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

jmsche
Copy link
Contributor

@jmsche jmsche commented Aug 16, 2023

Closes #18748.

Hi @weaverryan, could you please have a look at this? Thanks 😄

@jmsche
Copy link
Contributor Author

jmsche commented Aug 16, 2023

Hmm Doctor RST asked me to rename $builder to $container, so I did, but now it wants me to also rename $configurator to $container... This won't work.

The Code Blocks workflow complains about Symfony\Component\AssetMapper\AssetMapperInterface not being available, but I guess I should add this component to https://github.com/symfony-tools/symfony-application?

@javiereguiluz javiereguiluz merged commit 40d1634 into symfony:6.3 Sep 19, 2023
@javiereguiluz
Copy link
Member

@jmsche thanks for reporting all these issues and for fixing them yourself.

About the DOCtor-RST issue, I'll try to fix it in a separate PR. Thanks!

javiereguiluz added a commit that referenced this pull request Sep 19, 2023
…(javiereguiluz)

This PR was merged into the 6.3 branch.

Discussion
----------

Disable a DOCtor-RST rule for a specific file to fix CI

Fixes the issue introduced in #18755.

Commits
-------

8e78f74 Disable a DOCtor-RST rule for a specific file to fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants