[Form] Support Translatable Enum #18599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
the
Waiting Code Merge
derrabus
added a commit
to symfony/symfony
that referenced
this pull request
Jul 24, 2023
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Form] Support Translatable Enum | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #50919 | License | MIT | Doc PR | symfony/symfony-docs#18599 This PR introduce support for Enum implementing `TranslatableInterface` in `EnumType`. Example of use: ```php $builder->add('textAlign', EnumType::class, [ 'class' => TextAlign::class, ]) ``` ```php use Symfony\Contracts\Translation\TranslatableInterface; use Symfony\Contracts\Translation\TranslatorInterface; enum TextAlign: int implements TranslatableInterface { case Left = 1; case Center = 2; case Right = 3; public function trans(TranslatorInterface $translator, string $locale = null): string { // Translate enum from name (Left, Center or Right) return $translator->trans($this->name, locale: $locale); // Translate enum from custom labels return match ($this) { self::Left => $translator->trans('Left aligned', locale: $locale), self::Center => $translator->trans('Centered', locale: $locale), self::Right => $translator->trans('Right aligned', locale: $locale), }; } } ``` Commits ------- 65f26da [Form] Support Translatable Enum
symfony-splitter
pushed a commit
to symfony/form
that referenced
this pull request
Jul 24, 2023
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Form] Support Translatable Enum | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix symfony/symfony#50919 | License | MIT | Doc PR | symfony/symfony-docs#18599 This PR introduce support for Enum implementing `TranslatableInterface` in `EnumType`. Example of use: ```php $builder->add('textAlign', EnumType::class, [ 'class' => TextAlign::class, ]) ``` ```php use Symfony\Contracts\Translation\TranslatableInterface; use Symfony\Contracts\Translation\TranslatorInterface; enum TextAlign: int implements TranslatableInterface { case Left = 1; case Center = 2; case Right = 3; public function trans(TranslatorInterface $translator, string $locale = null): string { // Translate enum from name (Left, Center or Right) return $translator->trans($this->name, locale: $locale); // Translate enum from custom labels return match ($this) { self::Left => $translator->trans('Left aligned', locale: $locale), self::Center => $translator->trans('Centered', locale: $locale), self::Right => $translator->trans('Right aligned', locale: $locale), }; } } ``` Commits ------- 65f26dad9c [Form] Support Translatable Enum
derrabus
suggested changes
Jul 24, 2023
|
Code PR has been merged. |
|
We also need a |
|
Added |
derrabus
reviewed
Jul 27, 2023
OskarStark
approved these changes
Jul 27, 2023
|
Thanks for your work on this new feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for symfony/symfony#50931