Skip to content

[Testing] Response Assertions: add examples of headers #18553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

alexislefebvre
Copy link
Contributor

I didn't know if I had to write contentType, CONTENT_TYPE, etc.

So I checked and found the expected format.

@carsonbot carsonbot added this to the 5.4 milestone Jul 12, 2023
@alexislefebvre alexislefebvre changed the title Response Assertions: add examples of headers [Testing] Response Assertions: add examples of headers Jul 12, 2023
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition

@carsonbot carsonbot changed the title [Testing] Response Assertions: add examples of headers Response Assertions: add examples of headers Jul 13, 2023
@alexislefebvre
Copy link
Contributor Author

I doubled the backticks.

@carsonbot carsonbot changed the title Response Assertions: add examples of headers [Testing] Response Assertions: add examples of headers Jul 13, 2023
@javiereguiluz
Copy link
Member

Yes, it's better to show some examples to avoid wondering how to pass the header name. Thanks Alexis!

@javiereguiluz javiereguiluz merged commit cab866a into symfony:5.4 Jul 13, 2023
@alexislefebvre alexislefebvre deleted the patch-2 branch July 13, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants