Skip to content

[HttpClient] Add a note about requirement to use URI templates #18481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

clement-michelet
Copy link
Contributor

Closes #18480

@clement-michelet clement-michelet force-pushed the http-client-add-note-about-vendor-for-uri-templates/6.3 branch from 4bcf0a0 to e540d65 Compare July 3, 2023 06:45
@clement-michelet clement-michelet force-pushed the http-client-add-note-about-vendor-for-uri-templates/6.3 branch from e540d65 to 40c513d Compare July 3, 2023 06:53
@javiereguiluz javiereguiluz added this to the 6.3 milestone Jul 4, 2023
@javiereguiluz javiereguiluz merged commit 56a41b3 into symfony:6.3 Jul 4, 2023
@javiereguiluz
Copy link
Member

Clément, thanks a lot for this contribution.

I wasn't aware of this and I agree with you: depending on the app, this can be a big catch. So, while merging your proposed change, I reworded it (see 59ce75f) as follows:

  • Move it up to show it as early as possible
  • Instead of a note, let's merge it in the regular text
  • Instead of mentioning that "you need a vendor", propose a command to install one of those vendors and show the others as alternatives
  • Don't mention the option to pass a \Closure because it's just way too advanced for most (all?) readers

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants