Skip to content

Fix incorrect placement of is_empty_callback #18455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix incorrect placement of is_empty_callback #18455

merged 1 commit into from
Jun 26, 2023

Conversation

janklan
Copy link
Contributor

@janklan janklan commented Jun 26, 2023

I think the is_empty_callback placement is wrong in 6.3 docs. This PR fixes it.

image

@janklan janklan requested a review from xabbuh as a code owner June 26, 2023 02:29
@OskarStark OskarStark changed the title Fix incorrect placement of is_empty_callback Fix incorrect placement of is_empty_callback Jun 26, 2023
@OskarStark OskarStark added this to the 5.4 milestone Jun 26, 2023
@OskarStark OskarStark changed the base branch from 6.3 to 5.4 June 26, 2023 08:47
@OskarStark
Copy link
Contributor

OskarStark commented Jun 26, 2023

Thank you Jan and congratulations on your first contribution to the Symfony documentation 🎉

@OskarStark OskarStark merged commit b05fda5 into symfony:5.4 Jun 26, 2023
@janklan janklan deleted the 6.3 branch June 26, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants