Skip to content

Remove symfony 5.x version references #18431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alamirault
Copy link
Contributor

I think they should have been in versionadded directive and not in sentences

I'm right ?

@carsonbot carsonbot added this to the 7.0 milestone Jun 18, 2023
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should be merged into the 6.2 branch, right?

@OskarStark
Copy link
Contributor

Yes 6.2 please

@OskarStark OskarStark modified the milestones: 7.0, 6.2 Jun 18, 2023
@alamirault alamirault force-pushed the remove-symfony-version-references branch from 06cf170 to 5055fa7 Compare June 18, 2023 14:28
@alamirault alamirault changed the base branch from 7.0 to 6.2 June 18, 2023 14:28
@alamirault
Copy link
Contributor Author

Rebased on branch 6.2 😄

@javiereguiluz
Copy link
Member

Antoine, thanks for taking care of rewording all these contents

@javiereguiluz javiereguiluz merged commit 6bb7743 into symfony:6.2 Jun 19, 2023
@alamirault alamirault deleted the remove-symfony-version-references branch June 19, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants