[DependencyInjection] Warns instanceof should be called before services registration
#18346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatTheCat
force-pushed
the
php-di-configuration-order
branch
from
b92540e to
d56550a
Compare
MatTheCat
force-pushed
the
php-di-configuration-order
branch
from
d56550a to
7e31754
Compare
MatTheCat
force-pushed
the
php-di-configuration-order
branch
from
7e31754 to
c460d9b
Compare
MatTheCat
force-pushed
the
php-di-configuration-order
branch
from
c460d9b to
790a24e
Compare
MatTheCat
force-pushed
the
php-di-configuration-order
branch
from
790a24e to
0afc6f0
Compare
MatTheCat
force-pushed
the
php-di-configuration-order
branch
from
0afc6f0 to
5de7e5a
Compare
…ices registration
MatTheCat
force-pushed
the
php-di-configuration-order
branch
from
5de7e5a to
dc2d048
Compare
|
Thanks Mathieu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes symfony/symfony#49988 and symfony/symfony#50329
Order matters when configuring the service container using PHP.
Maybe we should warn about
defaultstoo but I’m not sure where 🤔