Skip to content

Use DOCtor-RST 1.47.1 #18323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2023
Merged

Use DOCtor-RST 1.47.1 #18323

merged 1 commit into from
May 22, 2023

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented May 19, 2023

@OskarStark OskarStark self-assigned this May 19, 2023
@OskarStark OskarStark changed the base branch from 6.2 to 5.4 May 19, 2023 08:05
@staabm
Copy link
Contributor

staabm commented May 19, 2023

👍

ship it :shipit:

@staabm
Copy link
Contributor

staabm commented May 19, 2023

are these reported DOCtor-RST errors regressions in the tool because of the recent changes?

@OskarStark
Copy link
Contributor Author

are these reported DOCtor-RST errors regressions in the tool because of the recent changes?

checking right now

@OskarStark
Copy link
Contributor Author

It looks like, yes

@staabm
Copy link
Contributor

staabm commented May 19, 2023

could you narrow it to one of the PRs?

@OskarStark
Copy link
Contributor Author

I need to check it next week

@staabm
Copy link
Contributor

staabm commented May 19, 2023

locally I cannot reproduce the errors. maybe we need to invalidate the CI cache?

@staabm
Copy link
Contributor

staabm commented May 21, 2023

I was able to narrow it to this PR OskarStark/doctor-rst#1407

@OskarStark OskarStark changed the title Use DOCtor-RST 1.47.0 Use DOCtor-RST 1.47.1 May 22, 2023
@OskarStark
Copy link
Contributor Author

Thanks @staabm for fixing the regression 👍

@OskarStark OskarStark merged commit 92da4d7 into symfony:5.4 May 22, 2023
@OskarStark OskarStark deleted the use-doctor-1.47 branch May 23, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants