Skip to content

Remove space end of line #18262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2023
Merged

Remove space end of line #18262

merged 1 commit into from
Apr 28, 2023

Conversation

alamirault
Copy link
Contributor

There is 6 occurences on 6.3.

Found with regex [a-zA-Z] $

If PR is accepted @OskarStark WDYT to add a Doctor rule ? Which name do you suggest ?

@carsonbot carsonbot added this to the 5.4 milestone Apr 26, 2023
@OskarStark
Copy link
Contributor

Nice one ☝🏻

Rule idea: RemoveTrailingWhitespace

?

@javiereguiluz
Copy link
Member

Thank you Antoine.

@javiereguiluz javiereguiluz merged commit b7fdf91 into symfony:5.4 Apr 28, 2023
@alamirault alamirault mentioned this pull request Apr 28, 2023
Merged
@alamirault alamirault deleted the feature/remove-space-end-of-line branch April 28, 2023 19:00
@alamirault alamirault mentioned this pull request May 2, 2023
Merged
OskarStark added a commit that referenced this pull request May 3, 2023
@OskarStark
minor #18276 Use Doctor RST 1.45.0 and new Rule `RemoveTrailingWhites…
1542d17 
…pace` (alamirault)

This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

Use Doctor RST 1.45.0 and new Rule `RemoveTrailingWhitespace`

Follow #18262

cc `@OskarStark`

Commits
-------

06eb904 Use Doctor RST 1.45.0 and new Rule `RemoveTrailingWhitespace`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alamirault @OskarStark @javiereguiluz @carsonbot