Skip to content

[Serializer] Add debug:serializer command #18211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

[Serializer] Add debug:serializer command #18211

merged 1 commit into from
Apr 26, 2023

Conversation

loic425
Copy link
Contributor

@loic425 loic425 commented Apr 14, 2023

Fixes #18208

@carsonbot carsonbot added this to the 6.3 milestone Apr 14, 2023
@mdoutreluingne
Copy link
Contributor

Versionadded directive is missing

@loic425
Copy link
Contributor Author

loic425 commented Apr 21, 2023 •
edited
Loading

@mdoutreluingne

Versionadded directive is missing

done

OskarStark
OskarStark reviewed Apr 26, 2023
View reviewed changes
OskarStark
OskarStark reviewed Apr 26, 2023
View reviewed changes
OskarStark
OskarStark reviewed Apr 26, 2023
View reviewed changes
serializer.rst Outdated
+----------------+------------------------------------------------------------+
| Property | Options |
+----------------+------------------------------------------------------------+
| firstArgument | [ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use something more real life instead of firstArgument ?

Maybe name and ISBN, because the groups also mention book

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

OskarStark
OskarStark reviewed Apr 26, 2023
View reviewed changes
OskarStark
OskarStark requested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

@OskarStark OskarStark changed the title [Serializer] Add Debug command [Serializer] Add debug:serializer command Apr 26, 2023
@OskarStark OskarStark force-pushed the docs/debug-serializer branch from 06b7114 to 2fe03a4 Compare April 26, 2023 15:33
@OskarStark
Copy link
Contributor

Thanks for your work on this new feature!

@OskarStark OskarStark merged commit 7fe9b3d into symfony:6.3 Apr 26, 2023
@loic425 loic425 deleted the docs/debug-serializer branch April 26, 2023 21:07
@javiereguiluz javiereguiluz mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@mdoutreluingne mdoutreluingne mdoutreluingne approved these changes

Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@loic425 @mdoutreluingne @OskarStark @carsonbot