Skip to content

[Routing] Changing RouterInterface => UrlGeneratorInterface #18192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

[Routing] Changing RouterInterface => UrlGeneratorInterface #18192

merged 1 commit into from
Apr 13, 2023

Conversation

ThomasLandauer
Copy link
Contributor

Further up on the page it's advised to use UrlGeneratorInterface as typehint. I don't know what the difference is, but I'm guessing that it saves you from use RouterInterface (if you need the UrlGeneratorInterface for something else anyway, as in this example). Is this right?

@ThomasLandauer ThomasLandauer changed the title Chaning RouterInterface => UrlGeneratorInterface Changing RouterInterface => UrlGeneratorInterface Apr 11, 2023
@ThomasLandauer
Copy link
Contributor Author

Could probably be done in v5.4 already.

@carsonbot carsonbot changed the title Changing RouterInterface => UrlGeneratorInterface [Routing] Changing RouterInterface => UrlGeneratorInterface Apr 13, 2023
@javiereguiluz javiereguiluz added this to the 5.4 milestone Apr 13, 2023
@ThomasLandauer @javiereguiluz
Chaning RouterInterface => UrlGeneratorInterface
1e9f451 
Further up on the page it's advised to use `UrlGeneratorInterface` as typehint. I don't know what the difference is, but I'm guessing that it saves you from `use RouterInterface` (if you need the `UrlGeneratorInterface` for something else anyway, as in this example).
Is this right?
@javiereguiluz javiereguiluz changed the base branch from 6.2 to 5.4 April 13, 2023 10:31
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner April 13, 2023 10:31
@javiereguiluz
Copy link
Member

Thanks Thomas.

@javiereguiluz javiereguiluz merged commit 556b108 into symfony:5.4 Apr 13, 2023
@ThomasLandauer ThomasLandauer deleted the patch-10 branch April 13, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Routing Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasLandauer @javiereguiluz @carsonbot