Skip to content

Suggest settings trusted proxies via env var for more traditional infrastructure #18157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

pyrech
Copy link
Contributor

@pyrech pyrech commented Apr 2, 2023

Looking at the first .env suggestion from the article could be dangerous if one does not see it's from the chapter explaining how to trust all proxies.

@carsonbot carsonbot added this to the 5.4 milestone Apr 2, 2023
@pyrech pyrech changed the title Suggest Flex config for more traditional infrastructure Suggest trusted proxies via Flex for more traditional infrastructure Apr 2, 2023
@pyrech
Copy link
Contributor Author

pyrech commented Apr 2, 2023

After some thoughts, I wonder if it should mention Flex at all because since Symfony 5.2, the trusted proxies is no longer configured by default in recipes (recipe of 5.2 VS 5.1)

@nicolas-grekas
Copy link
Member

True, this is unrelated to flex.

@pyrech pyrech changed the title Suggest trusted proxies via Flex for more traditional infrastructure Suggest settings trusted proxies via env var for more traditional infrastructure Apr 21, 2023
@pyrech
Copy link
Contributor Author

pyrech commented Apr 21, 2023

I removed mention to Flex 👍

@OskarStark
Copy link
Contributor

Thank you Loïck.

@OskarStark OskarStark merged commit 1436b8b into symfony:5.4 Apr 26, 2023
@OskarStark
Copy link
Contributor

I unmerged this PR to 6.2 and 6.3.

@pyrech can you please double check if place for the tip is ok for you in 6.2 branch? If not please provide a PR and ping me, thanks

@pyrech pyrech deleted the patch-2 branch April 26, 2023 08:58
@pyrech
Copy link
Contributor Author

pyrech commented Apr 26, 2023

It looks good to me, thanks @OskarStark!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants