Skip to content

Update HTML Sanitizer doc for max_input_length option #18147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tristan-lg
Copy link
Contributor

@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.2, 6.3.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 6.1 milestone Mar 30, 2023
@tristan-lg tristan-lg changed the base branch from 6.1 to 6.2 March 30, 2023 16:15
@tristan-lg tristan-lg force-pushed the add-max-input-length-documentation branch from 4434689 to b4acb94 Compare March 30, 2023 16:20
@OskarStark
Copy link
Contributor

friendly ping @tgalopin

@tristan-lg
Copy link
Contributor Author

Do you know why the "CI/Code Blocks" fails ?

Copy link
Contributor

@tgalopin tgalopin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also explain why if you want (it's because it's a source of DoS attacks)

Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
@javiereguiluz javiereguiluz modified the milestones: 6.1, 6.2 Apr 3, 2023
javiereguiluz added a commit that referenced this pull request Apr 3, 2023
…(t.le-gacque, tristan-lg)

This PR was merged into the 6.2 branch.

Discussion
----------

Update HTML Sanitizer doc for `max_input_length` option

Add missing documentation for https://symfony.com/doc/current/html_sanitizer.html#allow-elements

Related to the bug symfony/symfony#49040

Commits
-------

370b3d9 Apply suggestions from code review
7011d17 Update HTML Sanitizer doc for `max_input_length` option
6d2e21c Update HTML Sanitizer doc for `max_input_length` option
ce02cd4 Update HTML Sanitizer doc for `max_input_length` option
@javiereguiluz
Copy link
Member

Tristan, thanks and congrats on a great first Symfony Docs contribution 🎉

Thanks to reviewers too 🙌

@javiereguiluz
Copy link
Member

javiereguiluz commented Apr 3, 2023

Closing manually as merged. GitHub shows it as "closed", but it was merged; see e39cbf6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants