[Security] Add statusCode and message arguments to #[IsGranted]
#18103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great thanks @alexandre-daubois! I was searching for it after looking at your last PR! |
|
I am also tempted to explicitly specify the default status code, and maybe document |
alexandre-daubois
force-pushed
the
isgranted-status-code
branch
from
eceb5fa to
7961840
Compare
|
Updated! What do you think? |
alexandre-daubois
changed the title
statusCode to #[IsGranted]statusCode and message arguments to #[IsGranted]
MrYamous
reviewed
Mar 20, 2023
security.rst
Outdated
|
|
||
| use Symfony\Component\Security\Http\Attribute\IsGranted; | ||
|
|
||
| #[IsGranted('ROLE_ADMIN', statusCode: 403)] |
There was a problem hiding this comment.
I think we can keep a custom statusCode here and specify in text above 403 is default value, seems confusing to me to explicitly define default value here
There was a problem hiding this comment.
You're right, updated!
OskarStark
changed the title
statusCode and message arguments to #[IsGranted]statusCode and message arguments to #[IsGranted]
OskarStark
reviewed
Mar 21, 2023
security.rst
Outdated
| class AdminController extends AbstractController | ||
| { | ||
| // ... | ||
| } | ||
|
|
||
| The default code is 403. |
There was a problem hiding this comment.
Suggested change
| The default code is 403. |
already mentioned in the sentence above. Afterwards good to merge 👍
|
Thank you @alexandre-daubois. |
OskarStark
force-pushed
the
isgranted-status-code
branch
from
17ceb21 to
149d33b
Compare
OskarStark
added a commit
that referenced
this pull request
Mar 21, 2023
…#[IsGranted]` (alexandre-daubois) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [Security] Add `statusCode` and `message` arguments to `#[IsGranted]` Following #18101 (comment) Commits ------- 149d33b [Security] Add `statusCode` and `message` arguments to `#[IsGranted]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #18101 (comment)